bbb2f41591
- Created `openspec-ff-change` skill for fast-forward artifact creation. - Introduced `openspec-new-change` skill for structured change creation. - Developed `openspec-onboard` skill for guided onboarding through OpenSpec workflow. - Added `openspec-sync-specs` skill for syncing delta specs to main specs. - Implemented `openspec-verify-change` skill for verifying implementation against change artifacts. - Updated `.gitignore` to exclude OpenSpec generated files. - Added `skills-lock.json` to manage skill dependencies.
36 lines
1018 B
Markdown
36 lines
1018 B
Markdown
---
|
|
title: Do not wrap a simple expression with a primitive result type in useMemo
|
|
impact: LOW-MEDIUM
|
|
impactDescription: wasted computation on every render
|
|
tags: rerender, useMemo, optimization
|
|
---
|
|
|
|
## Do not wrap a simple expression with a primitive result type in useMemo
|
|
|
|
When an expression is simple (few logical or arithmetical operators) and has a primitive result type (boolean, number, string), do not wrap it in `useMemo`.
|
|
Calling `useMemo` and comparing hook dependencies may consume more resources than the expression itself.
|
|
|
|
**Incorrect:**
|
|
|
|
```tsx
|
|
function Header({ user, notifications }: Props) {
|
|
const isLoading = useMemo(() => {
|
|
return user.isLoading || notifications.isLoading
|
|
}, [user.isLoading, notifications.isLoading])
|
|
|
|
if (isLoading) return <Skeleton />
|
|
// return some markup
|
|
}
|
|
```
|
|
|
|
**Correct:**
|
|
|
|
```tsx
|
|
function Header({ user, notifications }: Props) {
|
|
const isLoading = user.isLoading || notifications.isLoading
|
|
|
|
if (isLoading) return <Skeleton />
|
|
// return some markup
|
|
}
|
|
```
|